HDFS-16815. Error occurred in processing CacheManagerSection for xml parsing fsimage#5069
Closed
meijing123 wants to merge 1 commit intoapache:trunkfrom
Closed
HDFS-16815. Error occurred in processing CacheManagerSection for xml parsing fsimage#5069meijing123 wants to merge 1 commit intoapache:trunkfrom
meijing123 wants to merge 1 commit intoapache:trunkfrom
Conversation
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
Please fix the failed unit test and checkstyle warn. |
|
💔 -1 overall
This message was automatically generated. |
jojochuang
requested changes
Oct 25, 2022
...fs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java
Outdated
Show resolved
Hide resolved
...fs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java
Outdated
Show resolved
Hide resolved
...fs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java
Outdated
Show resolved
Hide resolved
f09556b to
c3f2f36
Compare
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
The failed test looks related. Can you check? |
c3f2f36 to
ecaf2fe
Compare
|
💔 -1 overall
This message was automatically generated. |
5595855 to
842387b
Compare
2. We fixed two bugs in the processor of CacheManagerSectionProcessor to make sure the xml parsing fsimage.
842387b to
866f63f
Compare
|
💔 -1 overall
This message was automatically generated. |
Author
@jojochuang Hi. I have checked the faild unit test. The failed UT hadoop.hdfs.TestLeaseRecovery2 is traced by HDFS-16853. The failed test does not involve the code I modified。 |
|
Hi @tomscut , please help us review this pr again when you are available, Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
How was this patch tested?
We add a test method in TestOfflineImageViewer.java. The meyhod name is testReverseXmlWithCacheManagerSection.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?